Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show correct log for outbound message #272

Merged
merged 11 commits into from
Dec 14, 2022

Conversation

Souvikns
Copy link
Member

Description

This PR aims to change the outBoundMessage logs

Now, broadcast is logged when the send event is triggered for a websockets server.

image

Related issue(s)

Fixes #269

@coveralls
Copy link

coveralls commented Mar 14, 2022

Pull Request Test Coverage Report for Build 3646964278

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.321%

Totals Coverage Status
Change from base Build 3628566380: 0.0%
Covered Lines: 286
Relevant Lines: 310

💛 - Coveralls

@Souvikns Souvikns marked this pull request as draft March 14, 2022 10:13
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Souvikns Souvikns changed the title fix: show correct message for outbound message fix: show correct log for outbound message Mar 14, 2022
@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Jul 20, 2022
@fmvilas
Copy link
Member

fmvilas commented Jul 21, 2022

Removing stale label as we're waiting for #259 before continuing on this one.

@github-actions github-actions bot removed the stale label Jul 22, 2022
@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@Souvikns
Copy link
Member Author

Souvikns commented Dec 6, 2022

resuming work on this.

src/lib/functions.ts Outdated Show resolved Hide resolved
@Souvikns Souvikns marked this pull request as ready for review December 8, 2022 11:45
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please review your PR first? It has a looot of changes that are not related to logging outbound messages.

src/lib/functions.ts Outdated Show resolved Hide resolved
src/lib/util.ts Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Souvikns Souvikns requested a review from fmvilas December 13, 2022 11:11
@Souvikns
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit 0d4ff21 into asyncapi:master Dec 14, 2022
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.12.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logs show "broadcasted" when sending to a broker
4 participants